Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove myst parser from docs config #773

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Remove myst parser from docs config #773

merged 1 commit into from
Jul 5, 2023

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented Jul 5, 2023 •
edited
Loading

This PR removes the myst_parser from the docs as it is not needed. sphinx-asdf removed this the myst_parser recently.

Checklist

  • added entry in CHANGES.rst under the corresponding subsection
  • updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 5, 2023
@WilliamJamieson WilliamJamieson requested a review from braingram July 5, 2023 19:56
@WilliamJamieson WilliamJamieson marked this pull request as ready for review July 5, 2023 20:01
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner July 5, 2023 20:01
braingram
braingram approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Looks good to me!

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2396bc7) 76.91% compared to head (bc32c73) 76.91%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files          90       90           
  Lines        5466     5466           
=======================================
  Hits         4204     4204           
  Misses       1262     1262
Flag Coverage Δ *Carryforward flag
nightly 64.72% <ø> (ø) Carriedforward from 2396bc7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

schlafly
schlafly approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@WilliamJamieson WilliamJamieson merged commit 08a8e94 into spacetelescope:main Jul 5, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/docs branch July 5, 2023 20:30
@braingram braingram mentioned this pull request Jul 5, 2023
Merged
@WilliamJamieson WilliamJamieson mentioned this pull request Jul 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

@schlafly schlafly schlafly approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WilliamJamieson @braingram @schlafly